Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improved RTL support (mainly for the UITextField use-case) #140

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Improved RTL support (mainly for the UITextField use-case) #140

wants to merge 1 commit into from

Conversation

zfoltin
Copy link
Contributor

@zfoltin zfoltin commented Apr 9, 2021

Expose containerView to enable support for layoutMargins and semanticContentAttribute - mainly to improve the UITextField use-case for RTL languages.

Now it's possible to to add some spacing without a 'paddingView' and forceLeftToRight so the flag is on the left in RTL languages - see the sample app for details.

Simulator Screen Shot - iPhone 12 Pro Max - 2021-04-09 at 16 32 57

@zfoltin zfoltin mentioned this pull request Apr 9, 2021
Closed
@zfoltin
Copy link
Contributor Author

zfoltin commented May 30, 2021

Hey @kizitonwose any chance you can take a look at this? I'd love to see this released 🙏 🙇

1 similar comment
@zfoltin
Copy link
Contributor Author

zfoltin commented Sep 18, 2021

Hey @kizitonwose any chance you can take a look at this? I'd love to see this released 🙏 🙇

@zfoltin zfoltin force-pushed the improved-textfield-support branch from 570b34e to b2df9ad Compare December 31, 2021 17:05
@zfoltin
Copy link
Contributor Author

zfoltin commented Dec 31, 2021

Hello @kizitonwose, I see there has been some activity on this repo recently. Could you please take a look at this PR when you find the time?

@kizitonwose
Copy link
Owner

Hi @zfoltin , I'll get on it as soon as I find the time, sorry for the delays. You can use your branch with cocoapods as a workaround for now.

@MMohamad70
Copy link

I want to force my country picker to be LTR when the app in RTL.
Is it possible to merge this request or give me a workaround to handle this situation?

@zfoltin
Copy link
Contributor Author

zfoltin commented Oct 3, 2022

@MMohamad70 you can do what @kizitonwose suggests - use the PR's branch in Cocoapods. Something like
pod 'CountryPickerView', :git => 'https://github.com/zfoltin/CountryPickerView.git', :branch => 'improved-textfield-support'
If this ever gets merged and released 🤞 then I'll delete my fork so keep an eye 👀 on this PR, just in case...

@MMohamad70
Copy link

@zfoltin I didn't know I can use it this way. Thanks for your suggestion.

@zfoltin
Copy link
Contributor Author

zfoltin commented Oct 4, 2022

No worries @MMohamad70 👍 I hope @kizitonwose will find the time to review this PR and merge and publish it 🤞

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zfoltin @kizitonwose @MMohamad70